[
https://issues.apache.org/jira/browse/DRILL-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603135#comment-17603135
]
ASF GitHub Bot commented on DRILL-8117:
---------------------------------------
jnturton commented on code in PR #2499:
URL: https://github.com/apache/drill/pull/2499#discussion_r968538795
##########
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java:
##########
@@ -156,22 +159,25 @@ public void unauthorizedTarget() throws Exception {
@Test
public void invalidPolicy() throws Exception {
- thrownException.expect(new
UserExceptionMatcher(UserBitShared.DrillPBError.ErrorType.VALIDATION,
- "Invalid impersonation policies."));
+ String query = "ALTER SYSTEM SET `%s`='%s'";
Review Comment:
Ah, okay. In that case I think we can go two ways here, since upgrading this
test, or family of tests, to ClusterTest could be a significant expansion of
PR's scope.
1. We can merge this as it is and leave the ClusterTest work for another PR
or
2. we can expand the scope here and you can convert BaseTestImpersonation
from PlanTestBase to ClusterTest. I believe that ClusterTest offers the plan
string matching features in PlanTestBase.
I leave the choice for you to make based on which way you prefer to work.
> Clean up deprecated Apache code in Drill
> ----------------------------------------
>
> Key: DRILL-8117
> URL: https://issues.apache.org/jira/browse/DRILL-8117
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.20.1
> Reporter: Jingchuan Hu
> Priority: Major
> Fix For: 2.0.0
>
>
> Clean up and upgrade deprecated Apache code like:
> Class PathChildrenCache in Class ZookeeperClient and Class StringEscapeUtils
> in Class PlanStringBuilder
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
