[
https://issues.apache.org/jira/browse/DRILL-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17550950#comment-17550950
]
ASF GitHub Bot commented on DRILL-8242:
---------------------------------------
jnturton commented on PR #2568:
URL: https://github.com/apache/drill/pull/2568#issuecomment-1148553607
I have a question relating to the earlier PR #2566 for this conversion.
`JsonLoaderImpl` acquired a new `fromString` method, but it only needed to do
that to accommodate the String returned by `SimpleHttp::makeSimpleGetRequest`.
It seems to me that we can avoid copying scan data into a String on the heap
here by making `SimpleHttp::makeSimpleGetRequest` return a stream instead.
> Fix output for HttpHelperFunctions
> ----------------------------------
>
> Key: DRILL-8242
> URL: https://issues.apache.org/jira/browse/DRILL-8242
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Functions - Drill
> Reporter: Vitalii Diravka
> Assignee: Vitalii Diravka
> Priority: Critical
> Fix For: 2.0.0
>
>
> DRILL-8236 changed HttpHelperFunctions to use EVF based JSON v2 reader. But
> function output left old
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
