[ 
https://issues.apache.org/jira/browse/DRILL-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551157#comment-17551157
 ] 

ASF GitHub Bot commented on DRILL-8242:
---------------------------------------

jnturton commented on code in PR #2568:
URL: https://github.com/apache/drill/pull/2568#discussion_r891124891


##########
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java:
##########
@@ -46,7 +51,9 @@ public class ProjectRecordBatch extends 
AbstractSingleRecordBatch<Project> {
   private static final Logger logger = 
LoggerFactory.getLogger(ProjectRecordBatch.class);
 
   protected List<ValueVector> allocationVectors;
+  @Deprecated // use new writer rsLoader

Review Comment:
   Just checking that I understand here: it's still possible for UDFs like 
`convert_fromJSON` to use org.apache.drill.exec.vector.complex.fn.JsonReader 
because it is only deprecated, not removed? But we could convert those in 
future too?





> Fix output for HttpHelperFunctions
> ----------------------------------
>
>                 Key: DRILL-8242
>                 URL: https://issues.apache.org/jira/browse/DRILL-8242
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Functions - Drill
>            Reporter: Vitalii Diravka
>            Assignee: Vitalii Diravka
>            Priority: Critical
>             Fix For: 2.0.0
>
>
> DRILL-8236 changed HttpHelperFunctions to use EVF based JSON v2 reader. But 
> function output left old



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to