[
https://issues.apache.org/jira/browse/DRILL-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551081#comment-17551081
]
ASF GitHub Bot commented on DRILL-8242:
---------------------------------------
vdiravka commented on code in PR #2568:
URL: https://github.com/apache/drill/pull/2568#discussion_r891201812
##########
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java:
##########
@@ -75,9 +75,6 @@ public void eval() {
// as an approximation of null-if-null handling.
if (args == null) {
// Return empty map
- org.apache.drill.exec.vector.complex.writer.BaseWriter.MapWriter
mapWriter = writer.rootAsMap();
- mapWriter.start();
Review Comment:
We don't need it. but since it is `@Output`, the field is required for the
UDF signature and can't be removed. It can be checked one more time again once
`complexWriters` are removed from all UDFs.
I've added todo to remove it. I can back to it, once migrating some other
UDF to the new JSON parser
> Fix output for HttpHelperFunctions
> ----------------------------------
>
> Key: DRILL-8242
> URL: https://issues.apache.org/jira/browse/DRILL-8242
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Functions - Drill
> Reporter: Vitalii Diravka
> Assignee: Vitalii Diravka
> Priority: Critical
> Fix For: 2.0.0
>
>
> DRILL-8236 changed HttpHelperFunctions to use EVF based JSON v2 reader. But
> function output left old
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
