[ 
https://issues.apache.org/jira/browse/DRILL-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603618#comment-17603618
 ] 

ASF GitHub Bot commented on DRILL-8117:
---------------------------------------

kingswanwho commented on code in PR #2499:
URL: https://github.com/apache/drill/pull/2499#discussion_r969746071


##########
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java:
##########
@@ -156,22 +159,25 @@ public void unauthorizedTarget() throws Exception {
 
   @Test
   public void invalidPolicy() throws Exception {
-    thrownException.expect(new 
UserExceptionMatcher(UserBitShared.DrillPBError.ErrorType.VALIDATION,
-        "Invalid impersonation policies."));
+    String query = "ALTER SYSTEM SET `%s`='%s'";

Review Comment:
   Hi James, I would like to apply the second way, since this PR has been 
existing for a while, it doesn't matter to wait for a bit longer : )





> Clean up deprecated Apache code in Drill
> ----------------------------------------
>
>                 Key: DRILL-8117
>                 URL: https://issues.apache.org/jira/browse/DRILL-8117
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.20.1
>            Reporter: Jingchuan Hu
>            Priority: Major
>             Fix For: 2.0.0
>
>
> Clean up and upgrade deprecated Apache code like: 
> Class PathChildrenCache in Class ZookeeperClient and Class StringEscapeUtils 
> in Class PlanStringBuilder
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to