[
https://issues.apache.org/jira/browse/FINERACT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163081#comment-17163081
]
Michael Vorburger commented on FINERACT-821:
--------------------------------------------
> Manthan Surkar what, if anything, is actually left to do on this issue now?
*
https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml
looks pretty good now?
* https://github.com/apache/fineract/pull/1019
* https://github.com/apache/fineract/pull/985
FINERACT-971 has follow-up for new additional checks.
> Enable and enforce (!) Checkstyle in Fineract
> ---------------------------------------------
>
> Key: FINERACT-821
> URL: https://issues.apache.org/jira/browse/FINERACT-821
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger
> Assignee: Manthan Surkar
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> as suggested in FINERACT-712, we really should enable Checkstyle in Fineract.
> My past experience in such matters, confirmed by FINERACT-702, is that these
> things only ever work and have a lasting effect if you bulk fix all
> violations and switch on enforcement. If you only report, it's mostly useless.
> As for specific Checkstyle rules, I have spent a fair amount of time in a
> past life on a project (which I'm currently no longer actively invoved in) to
> refine a what I believe to be "good" Checkstyle rule set, we could reuse this
> for Fineract (it's EPL licensed, so copy/pasting it is perfectly fine), see
> https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
