[
https://issues.apache.org/jira/browse/FINERACT-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135317#comment-17135317
]
Manthan Surkar commented on FINERACT-821:
-----------------------------------------
[~vorburger][~awasum] We need to think on two checkstyles currently:
Indentation and line length-
1. Line Length - I would say let spotless handle it, the reason is it does it
pretty well. Checkstyle acts dumb for this particularly checkstyles it expects
strings/names to also follow (Which we can remove by regex but there are many
corner cases and hard to handle). Spotless wrap the lines where it is best
possible ignores things we cannot wrap. That is what is expected ;)
2. Indentation - I am trying to make spotless and checkstyles match, but
unfortunately they want different indentations on some particulars instances.
Now we have an option to let checkstyle handle it or spotless, spotless wins
again because who wants to indent the lines themselves?
I have tested that spotless with current config does handle both this checks
correctly, what are your opinions?
> Enable and enforce (!) Checkstyle in Fineract
> ---------------------------------------------
>
> Key: FINERACT-821
> URL: https://issues.apache.org/jira/browse/FINERACT-821
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger
> Assignee: Manthan Surkar
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> as suggested in FINERACT-712, we really should enable Checkstyle in Fineract.
> My past experience in such matters, confirmed by FINERACT-702, is that these
> things only ever work and have a lasting effect if you bulk fix all
> violations and switch on enforcement. If you only report, it's mostly useless.
> As for specific Checkstyle rules, I have spent a fair amount of time in a
> past life on a project (which I'm currently no longer actively invoved in) to
> refine a what I believe to be "good" Checkstyle rule set, we could reuse this
> for Fineract (it's EPL licensed, so copy/pasting it is perfectly fine), see
> https://github.com/opendaylight/odlparent/blob/master/checkstyle/src/main/resources/odl_checks.xml
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
