Aman-Mittal commented on code in PR #5799:
URL: https://github.com/apache/fineract/pull/5799#discussion_r3132294302
##########
.github/workflows/build-mariadb.yml:
##########
@@ -1,12 +1,14 @@
name: Fineract Cargo & Unit- & Integration tests - MariaDB
-on: [push, pull_request]
+on:
+ workflow_call:
permissions:
contents: read
jobs:
test:
+ if: ${{ github.event_name != 'pull_request' ||
github.event.pull_request.head.repo.full_name == github.repository }}
Review Comment:
Please confirm me What am i seeing that you are trying to cache the Tests on
Push, What would happen if Someone does some major work (new feature or
changes) in their forked Branch and then raise PR like every PR. Will that work
on that. Im seeing it can fail on forked repo with new features. LIke we are
not caching e2e tests from forked repo due to security reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
