adamsaghy commented on code in PR #5799:
URL: https://github.com/apache/fineract/pull/5799#discussion_r3132310065
##########
.github/workflows/build-mariadb.yml:
##########
@@ -1,12 +1,14 @@
name: Fineract Cargo & Unit- & Integration tests - MariaDB
-on: [push, pull_request]
+on:
+ workflow_call:
permissions:
contents: read
jobs:
test:
+ if: ${{ github.event_name != 'pull_request' ||
github.event.pull_request.head.repo.full_name == github.repository }}
Review Comment:
I am not caching on push anything.
`Build-core` compiles and generates required files. Once everything built,
we are storing in cache the built files.
All workflow depends on `build-core` so that run first. Once it's finished,
we are fetching the built files (compiles classes, generated fineract-client,
etc.) from the cache and run the tests, build docker image, etc.
Why the change?
- All workflow was independent and standalone which means ALL of them were
compiling and regenerating files which is unnecessary and led to java heap
space issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
