Aman-Mittal commented on code in PR #5799:
URL: https://github.com/apache/fineract/pull/5799#discussion_r3132426206


##########
.github/workflows/build-mariadb.yml:
##########
@@ -1,12 +1,14 @@
 name: Fineract Cargo & Unit- & Integration tests - MariaDB
 
-on: [push, pull_request]
+on:
+  workflow_call:
 
 permissions:
   contents: read
 
 jobs:
   test:
+    if: ${{ github.event_name != 'pull_request' || 
github.event.pull_request.head.repo.full_name == github.repository }}

Review Comment:
   That's great, i would like to add a suggestion. Would it be feasible for you 
how many tests it ran in summary view at the end of the tests.
   
   Like It would be a good add too like how many tests passed, failed and 
skipped for more clarity. 
   
   I would still need time to review this PR more 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to