adamsaghy commented on code in PR #5799:
URL: https://github.com/apache/fineract/pull/5799#discussion_r3137729767
##########
.github/workflows/build-mariadb.yml:
##########
@@ -1,12 +1,14 @@
name: Fineract Cargo & Unit- & Integration tests - MariaDB
-on: [push, pull_request]
+on:
+ workflow_call:
permissions:
contents: read
jobs:
test:
+ if: ${{ github.event_name != 'pull_request' ||
github.event.pull_request.head.repo.full_name == github.repository }}
Review Comment:
> > @adamsaghy can you take a look at this
> > while on PR mode (Workflow ran on PR against apache) it is passing
> > https://github.com/apache/fineract/actions/runs/24848781995 (Build-core
This PR)
> > and this is a build core i ran on push (Alexander's clone branch with
your CI check applied)
> > https://github.com/Aman-Mittal/fineract/actions/runs/24881720723
> > While essential check is also passing. But necessary E2E tests are
failing. Wouldn't this cause problem as in PR mode those tests are skipped
entirely?
>
> https://github.com/Aman-Mittal/fineract/actions/runs/24881720723 seems
contains some failing tests which has nothing to do with CI execution and some
of them fails due to infra issues at github side...
@Aman-Mittal You might want to restart the failing jobs to see infra issues
goes away, but regarding failing integration test, it seems unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
