Aman-Mittal commented on code in PR #5799:
URL: https://github.com/apache/fineract/pull/5799#discussion_r3139527158
##########
.github/workflows/build-e2e-tests.yml:
##########
@@ -1,12 +1,14 @@
name: Fineract E2E Tests
-on: [push, pull_request]
+on:
+ workflow_call:
permissions:
contents: read
jobs:
test:
+ if: ${{ github.event_name != 'pull_request' ||
github.event.pull_request.head.repo.full_name == github.repository }}
Review Comment:
@adamsaghy Adding this would cause problem in this case (3 PR cases running
ok 1 will cause issue)
PR run check: -
https://github.com/adamsaghy/fineract/actions/runs/24901636866 - Basic checks
passed and e2e tests were skipped (Not ran) on pull request. (But should fail)
TestCase PR : https://github.com/adamsaghy/fineract/pull/3 (Check Passed)
and actual PR : https://github.com/apache/fineract/pull/5778 (Some Check Failed)
But if on push was triggered on my repo e2e failed
https://github.com/Aman-Mittal/fineract/actions/runs/24901635516
This should be addressed first. as I have Rebased the PR onto your branch
but still it not ran.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
