adamsaghy commented on code in PR #5799:
URL: https://github.com/apache/fineract/pull/5799#discussion_r3138234456
##########
.github/workflows/build-mariadb.yml:
##########
@@ -1,12 +1,14 @@
name: Fineract Cargo & Unit- & Integration tests - MariaDB
-on: [push, pull_request]
+on:
+ workflow_call:
permissions:
contents: read
jobs:
test:
+ if: ${{ github.event_name != 'pull_request' ||
github.event.pull_request.head.repo.full_name == github.repository }}
Review Comment:
> I have restarted the check, meanwhile can you also approve workflow runs
on PRs i have created. Then I can check more.
>
> My main concern is (hoping im wrong) that these optimizations skipping
integration and unless those got merged. We may not able see proper e2e tests
results before it gets merged.
>
> I have created those sample PRs to ensure that this situation can get
cleared early. (What would happen after merge). Does the PR checks suppressing
these failures or not.
Done, but some of them failing due to compilation issues or heap space :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
