adamsaghy commented on code in PR #5967:
URL: https://github.com/apache/fineract/pull/5967#discussion_r3450890667
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/DepositProductDataValidator.java:
##########
@@ -145,7 +145,9 @@ public void validateForFixedDepositUpdate(final String
json) {
validateDepositTermDetailForUpdate(element, baseDataValidator);
- validateChartsData(element, baseDataValidator);
+ if (fromApiJsonHelper.parameterExists(chartsParamName, element)) {
Review Comment:
This condition can be moved into `validateChartsData`, so the validator will
be unified (none of the other validate methods are wrapped in an if condition).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
