adamsaghy commented on code in PR #5967:
URL: https://github.com/apache/fineract/pull/5967#discussion_r3450916385
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/RecurringDepositProduct.java:
##########
@@ -150,6 +155,11 @@ public void validateDomainRules() {
}
private void validateDomainRules(final DataValidatorBuilder
baseDataValidator) {
+ if (getStartDate() != null && getCloseDate() != null &&
DateUtils.isBefore(getCloseDate(), getStartDate())) {
Review Comment:
This should be handled in validator, not in JPA entity. Please move this
logic out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
