adamsaghy commented on code in PR #5967:
URL: https://github.com/apache/fineract/pull/5967#discussion_r3450901843
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/DepositAccountDomainServiceJpa.java:
##########
@@ -271,6 +272,7 @@ public Long handleFDAccountMaturityClosure(final
FixedDepositAccount account, fi
}
ExternalId externalId = this.externalIdFactory.create();
+
this.depositAccountAssembler.validateProductApplicationDate(closedDate,
account.savingsProduct());
Review Comment:
I believe validations should occur as early as possible. Could we move this
validator to be executed as one of the initial steps and only begin processing
after it has successfully passed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
