ryux1 opened a new pull request, #495: URL: https://github.com/apache/fineract-backoffice-ui/pull/495
## What and why Register the `flash-outline` and `checkmark-done-outline` Ionicons referenced by the navigation configuration so those entries no longer render blank or trigger lazy-load warnings. The existing icon check only inspected `<ion-icon>` template bindings. It now also checks literal and hoisted icon names in the navigation configuration, preventing another navigation-only icon from bypassing CI. Closes #485 ## Verification - `npm run check:icons` — 117 registered icons - `npm run lint` - `npm run format:check` - `npm run test:scripts` — 28 passed - `npm test -- --watch=false` — 236 files, 1,382 tests passed - `npm run build` ## Screenshots Not captured. This restores the SVGs for two existing navigation entries; the registry check covers both names and the production bundle resolves both imported icon definitions. ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] No new component or service code was added; the adapter boundary is unchanged. - [x] No user-facing strings were added. - [x] I extended the existing icon registry check to cover navigation configuration. - [x] No workflow behavior changed; e2e coverage is not applicable to static icon registration. - [x] Commits are signed — see [Commit Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
