adamsaghy commented on PR #6332: URL: https://github.com/apache/fineract/pull/6332#issuecomment-5570833801
**Resolved in code** - Accrual date no longer the COB businessDate — :82-89 uses submittedOnDate/dueDate per charge-accrual-date. - e2e config leak — restored via the @After hook, GlobalConfigurationStepDef.java:49; trailing in-scenario resets removed. - The ConfigurationDomainService interface change is gone; the new config reads through GlobalConfigurationRepositoryWrapper like its sibling. **Open** 1. Dead field. :25 + :66 still inject ConfigurationDomainService, never read. Soma believes this was removed; only the interface method was. One-line delete, checkstyle won't flag it. 2. eod → real-time switch gap (substantive, and not addressed by any of the four replies). A charge added under eod with the config flipped to real-time before the next COB is skipped by the sweep permanently (:81) and only accrues at closure, dated the closing date. This is a valid configuration, not a typo, so "misconfigured on purpose" doesn't cover it. Fix: let the COB sweep always run on the charge-accrual-date rule and have real-time only additionally post at add time — isAlreadyAccrued (:154) already makes that idempotent. 3. Unknown config value — Soma's call to leave it, which I'd accept, but a .trim() and a log.warn are worth it: the failure mode is fee/penalty income silently unrecognized tenant-wide until closure, and nothing validates the value on write. 4. Undocumented behavior changes — that real-time ignores charge-accrual-date, and that existing submitted-date tenants now get the accrual at the next COB (or, if the loan closes first, dated the closing date rather than submittedOnDate). Both belong in the PR description / release note. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
