mariiaKraievska commented on PR #6332: URL: https://github.com/apache/fineract/pull/6332#issuecomment-5602040542
@galovics I addressed the open review points in the latest push: Switch eod → real-time gap COB now always sweeps by charge-accrual-date, regardless of wcl-charge-accrual-time. Real-time only adds an immediate post-on-add path; isAlreadyAccrued keeps both idempotent. Added e2e UC9 (due-date pending after flip) and UC10 (submitted-date pending before next COB). Unrecognized config value Unknown / mistyped values now fall back to EOD (after trim), instead of making both posting paths no-ops. Dead ConfigurationDomainService field Removed. Missing submitted-date COB guard EOD, submitted-date path now filters with !submittedOnDate.isAfter(businessDate), same idea as the due-date branch, so catch-up COB cannot post an accrual dated after the day being processed. @galovics PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
