mariiaKraievska commented on PR #6332: URL: https://github.com/apache/fineract/pull/6332#issuecomment-5616096507
> Can you please check the below two things? > > WorkingCapitalLoanChargeAccrualService.java:75 — with the new default (EOD) plus charge-accrual-date=submitted-date, a charge added to an overpaid loan is never accrued. processOnChargeAdded is now a no-op, applyChargeDrivenLifecycle leaves the loan OVERPAID or closes it (:293-311), COB excludes closed/overpaid loans (WorkingCapitalLoanRetrieveIdServiceImpl.java:43), and createLoanCharge never calls accrueOnClosure. The fee is settled from the overpayment but no accrual/JE is ever posted — a regression, since the pre-PR on-add path covered it. An accrueOnClosure(loan, businessDate) after the lifecycle block would close the gap. > > WorkingCapitalLoanChargeAccrualService.java:90 — retrieveChargeAccrualDateConfig() is called twice (both branches), and both branches repeat the same charge query. Two config lookups per loan per COB run; hoist the mode and the charge list, and vary only the date extractor. Thanks for catching these. Both fixed in the latest push. Overpaid + EOD + submitted-date — added accrueOnClosure in createLoanCharge after processOnChargeAdded, plus e2e UC11 covering the gap. COB duplicate lookup — moved the accrual-date mode and charge list into local variables so they are read once -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
