budaidev commented on PR #6554:
URL: https://github.com/apache/fineract/pull/6554#issuecomment-6215646677
Thanks @galovics. Rebased onto develop. The migration is now 0089, since
other PRs took the number, so whichever of us merges second renumbers.
Re-approval after undo is fixed, but in the undo approval rather than on
approval. Undo approval now copies the leftover schedule's frequency to the
loan when they differ. Checking for a model stored without a frequency would
miss one case. Undo disbursal rebuilds the schedule with an explicit DAYS/1
while the loan still says 30 DAYS. Doing it on approval would also ignore a
modify made after the undo.
undoPayment now matches on the payment date and falls back to the due date
for older entries. I don't think it could change a result today, because only
the latest transaction is undone in place. It did leave the wrong day in the
model, though.
I also fixed a related case. A fee-only repayment on the disbursement date
reached the model with zero principal and moved every due date a month earlier.
Zero-principal payments are now skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
