adamsaghy commented on PR #6554: URL: https://github.com/apache/fineract/pull/6554#issuecomment-6223301819
> ## Review > Thanks @budaidev, nice round. Fixing the re-approval case in undo approval makes sense to me, it also covers the undo disbursal path and doesn't override a modify done after the undo. `undoPayment` now matches on the payment date with the legacy fallback, the migration moved to 0089 (no clash with develop now that #6640 is in as 0088), and the description covers the behaviour changes. Good catch on the fee-only disbursement-date repayment too. > > One thing is still open: > > `ProjectedAmortizationScheduleRepaymentFrequencyTest.java` (`monthly_repaymentOnTheDisbursementDate_movesEveryDueDateOnePeriodEarlier`): > > > The fee-only case is fixed, but my original question is still unanswered: on a monthly loan, a principal repayment on the disbursement date still moves every due date and the maturity one month earlier, and this test locks it in. For a daily schedule that's a one day shift, on a monthly one it's a whole month. Is this what the product wants, or is it left over from the daily design? @adamsaghy can you confirm? If it's intended, I'm fine with it, but let's put a sentence about it in the description. > > Once that's answered and the build is green I'm happy to approve. > > Recommendation: COMMENT yes, it is intended behaviour -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
