pjj-22 opened a new pull request, #6739: URL: https://github.com/apache/fineract/pull/6739
Share purchases and redemptions had nowhere to record how the money moved, and the share accounting bridge passed a null paymentTypeId to journal entries (marked FIXME), so payment-type GL routing never applied to shares. applyadditionalshares and redeemshares now accept the standard payment detail fields. They are validated the same way as account transfers and saved through PaymentDetailWritePlatformService, as savings deposits do. The share transaction links to the payment detail through a new payment_detail_id column (migration 0273, with the index created concurrently on PostgreSQL). Its payment type now reaches the journal entry, and purchased share transactions return paymentDetailData. Routing also needs a mapping on the product, which share products could not store: paymentChannelToFundSourceMappings was rejected as an unsupported parameter, and the mapping code saved share mappings through the savings helper, which would have recorded them as savings product mappings. Share products now accept and validate the mappings on create and update, and save them as share mappings. Assisted-By: claude-opus-5-5 ## Description Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
