adamsaghy commented on PR #6739: URL: https://github.com/apache/fineract/pull/6739#issuecomment-6483650006
Thanks for this. The payment-channel routing and the integration tests look good. Before we can merge, could you: 1. **Rebase onto current `develop`.** The PR now conflicts. Develop has since taken tenant changelog numbers `0274` and `0275`, so please renumber your migration to the next free number and keep the include order in `changelog-tenant.xml`. Please keep it as a single FINERACT-2105 commit, and fix the message, which still says `0273`. 2. **Don't let approve/reject accept payment detail.** The payment-detail fields were added to `addtionalSharesParameters`, which `validateAndApproveAddtionalShares` and `validateAndRejectAddtionalShares` also use. Those requests now accept `paymentTypeId`, `receiptNumber`, etc. and silently drop them, where they used to get a 400. Please give apply/redeem their own parameter set, so approve/reject still reject unknown fields. 3. **Initial purchase.** FINERACT-2105 covers share purchases in general, but the purchase made when the share account is submitted or activated still can't carry payment detail, so it always posts to the default share reference account. Please add support for it, with a test, or tell us if you want it handled in a follow-up ticket instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
