[ 
https://issues.apache.org/jira/browse/FLINK-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505534#comment-14505534
 ] 

ASF GitHub Bot commented on FLINK-1523:
---------------------------------------

Github user andralungu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/537#discussion_r28811435
  
    --- Diff: 
flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/example/IncrementalSSSPITCase.java
 ---
    @@ -0,0 +1,84 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.graph.test.example;
    +
    +import com.google.common.base.Charsets;
    +import com.google.common.io.Files;
    +import org.apache.flink.graph.example.IncrementalSSSPExample;
    +import org.apache.flink.graph.example.utils.IncrementalSSSPData;
    +import org.apache.flink.test.util.MultipleProgramsTestBase;
    +import org.junit.After;
    +import org.junit.Before;
    +import org.junit.Rule;
    +import org.junit.Test;
    +import org.junit.rules.TemporaryFolder;
    +import org.junit.runner.RunWith;
    +import org.junit.runners.Parameterized;
    +
    +import java.io.File;
    +
    +@RunWith(Parameterized.class)
    +public class IncrementalSSSPITCase extends MultipleProgramsTestBase {
    +
    +   private String verticesPath;
    +
    +   private String edgesPath;
    +
    +   private String edgesInSSSPPath;
    +
    +   private String resultPath;
    +
    +   private String expected;
    +
    +   @Rule
    +   public TemporaryFolder tempFolder = new TemporaryFolder();
    +
    +   public IncrementalSSSPITCase(TestExecutionMode mode) {
    +           super(mode);
    +   }
    +
    +   @Before
    +   public void before() throws Exception {
    +           resultPath = tempFolder.newFile().toURI().toString();
    +           File verticesFile = tempFolder.newFile();
    +           Files.write(IncrementalSSSPData.VERTICES, verticesFile, 
Charsets.UTF_8);
    +
    +           File edgesFile = tempFolder.newFile();
    +           Files.write(IncrementalSSSPData.EDGES, edgesFile, 
Charsets.UTF_8);
    +
    +           File edgesInSSSPFile = tempFolder.newFile();
    +           Files.write(IncrementalSSSPData.EDGES_IN_SSSP, edgesInSSSPFile, 
Charsets.UTF_8);
    +
    +           verticesPath = verticesFile.toURI().toString();
    +           edgesPath = edgesFile.toURI().toString();
    +           edgesInSSSPPath = edgesInSSSPFile.toURI().toString();
    +   }
    +
    +   @Test
    --- End diff --
    
    The test for removing the non-SP-edge is doable. It's the bigger graph test 
case that concerns me. Of course, we can generate some randomised edges, but 
how do we know which of those edges are in SSSP? That can only be done if we 
have the actual algorithm implemented.


> Vertex-centric iteration extensions
> -----------------------------------
>
>                 Key: FLINK-1523
>                 URL: https://issues.apache.org/jira/browse/FLINK-1523
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>            Reporter: Vasia Kalavri
>            Assignee: Andra Lungu
>
> We would like to make the following extensions to the vertex-centric 
> iterations of Gelly:
> - allow vertices to access their in/out degrees and the total number of 
> vertices of the graph, inside the iteration.
> - allow choosing the neighborhood type (in/out/all) over which to run the 
> vertex-centric iteration. Now, the model uses the updates of the in-neighbors 
> to calculate state and send messages to out-neighbors. We could add a 
> parameter with value "in/out/all" to the {{VertexUpdateFunction}} and 
> {{MessagingFunction}}, that would indicate the type of neighborhood.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to