[ 
https://issues.apache.org/jira/browse/FLINK-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505565#comment-14505565
 ] 

ASF GitHub Bot commented on FLINK-1523:
---------------------------------------

Github user andralungu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/537#discussion_r28812911
  
    --- Diff: 
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexCentricIteration.java
 ---
    @@ -228,48 +213,92 @@ public void setInput(DataSet<Vertex<VertexKey, 
VertexValue>> inputData) {
        {
                return new VertexCentricIteration<VertexKey, VertexValue, 
Message, EdgeValue>(uf, mf, edgesWithValue, maximumNumberOfIterations);
        }
    -   
    +
    +   /**
    +    * Configures this vertex-centric iteration with the provided 
parameters.
    +    *
    +    * @param parameters the configuration parameters
    +    */
    +   public void configure(IterationConfiguration parameters) {
    +           this.configuration = parameters;
    +   }
    +
    +   /**
    +    * @return the configuration parameters of this vertex-centric iteration
    +    */
    +   public IterationConfiguration getIterationConfiguration() {
    +           return this.configuration;
    +   }
    +
        // 
--------------------------------------------------------------------------------------------
        //  Wrapping UDFs
        // 
--------------------------------------------------------------------------------------------
        
    -   private static final class VertexUpdateUdf<VertexKey extends 
Comparable<VertexKey> & Serializable, 
    -           VertexValue extends Serializable, Message> 
    -           extends RichCoGroupFunction<Tuple2<VertexKey, Message>, 
Vertex<VertexKey, VertexValue>, Vertex<VertexKey, VertexValue>>
    -           implements ResultTypeQueryable<Vertex<VertexKey, VertexValue>>
    +   private static abstract class VertexUpdateUdf<VertexKey extends 
Comparable<VertexKey> & Serializable,
    +           VV extends Serializable, VertexValue extends Serializable, 
Message>
    --- End diff --
    
    Perhaps I chose a name that is a bit misleading, here VV is replaced by the 
Tuple3<VertexValue, InDegree, OutDegree> when you have the  degrees option set 
or simply VertexValue if the degrees are not set. I still need the VertexValue 
generic type. I can rename VertexValue to VV, EdgeValue to EV, etc and VV to 
something else? Something like  VertexValueMessagingFunction. I can't think of 
a better name :) 
    
    Tell me if my intention is clearer now and how to proceed!


> Vertex-centric iteration extensions
> -----------------------------------
>
>                 Key: FLINK-1523
>                 URL: https://issues.apache.org/jira/browse/FLINK-1523
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>            Reporter: Vasia Kalavri
>            Assignee: Andra Lungu
>
> We would like to make the following extensions to the vertex-centric 
> iterations of Gelly:
> - allow vertices to access their in/out degrees and the total number of 
> vertices of the graph, inside the iteration.
> - allow choosing the neighborhood type (in/out/all) over which to run the 
> vertex-centric iteration. Now, the model uses the updates of the in-neighbors 
> to calculate state and send messages to out-neighbors. We could add a 
> parameter with value "in/out/all" to the {{VertexUpdateFunction}} and 
> {{MessagingFunction}}, that would indicate the type of neighborhood.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to