Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r116261121
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala
---
@@ -37,14 +39,18 @@ import org.apache.flink.types.Row
* Flink RelNode which matches along with JoinOperator and its related
operations.
*/
class DataStreamJoin(
- cluster: RelOptCluster,
- traitSet: RelTraitSet,
- leftNode: RelNode,
- rightNode: RelNode,
- joinNode: FlinkLogicalJoin,
- leftSchema: RowSchema,
- schema: RowSchema,
- ruleDescription: String)
+ cluster: RelOptCluster,
+ traitSet: RelTraitSet,
+ leftNode: RelNode,
+ rightNode: RelNode,
+ joinCondition: RexNode,
+ joinInfo: JoinInfo,
--- End diff --
`JoinInfo` can be computed from `leftNode`, `rightNode`, and `condition`.
No need to pass it as a parameter, IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
