Github user rtudoran commented on a diff in the pull request:
https://github.com/apache/flink/pull/3715#discussion_r116397441
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala
---
@@ -199,31 +157,38 @@ object JoinUtil {
val generator = new CodeGenerator(
config,
nullCheck,
- returnType)
+ leftType,
+ Some(rightType))
+
+ val conversion = generator.generateConverterResultExpression(
+ returnType.physicalTypeInfo,
+ returnType.physicalType.getFieldNames)
// if other condition is null, the filterfunc always return true
val body = if (otherCondition == null) {
--- End diff --
@fhueske @hongyuhong - i think it is Lietral(True)...at least when i was
working with inner queries i was always testing for an always true condition
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
