Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3715#discussion_r116272041
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala
 ---
    @@ -44,12 +48,18 @@ import org.apache.flink.util.Collector
     class ProcTimeInnerJoin(
       private val leftStreamWindowSize: Long,
       private val rightStreamWindowSize: Long,
    -  private val element1Type: TypeInformation[CRow],
    -  private val element2Type: TypeInformation[CRow],
    -  private val filterFunc: RichFilterFunction[Row])
    -  extends CoProcessFunction[CRow, CRow, CRow] {
    +  private val element1Type: TypeInformation[Row],
    +  private val element2Type: TypeInformation[Row],
    +  private val genJoinFunc: GeneratedFunction[FlatJoinFunction[Row, Row, 
Row], Row])
    --- End diff --
    
    The other functions pass the `code` and `name` of the class and have 
`@transient` parameter for the `returnType`. Have a look at `CRowFlatMapRunner` 
for instance


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to