[
https://issues.apache.org/jira/browse/FLINK-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013705#comment-16013705
]
ASF GitHub Bot commented on FLINK-6583:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3919#discussion_r116932844
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/triggers/StateCleaningCountTrigger.scala
---
@@ -19,44 +19,46 @@ package org.apache.flink.table.runtime.triggers
import java.lang.{Long => JLong}
+import org.apache.flink.annotation.PublicEvolving
import org.apache.flink.api.common.functions.ReduceFunction
import org.apache.flink.api.common.state._
import
org.apache.flink.streaming.api.windowing.triggers.Trigger.TriggerContext
import org.apache.flink.streaming.api.windowing.triggers.{Trigger,
TriggerResult}
-import org.apache.flink.streaming.api.windowing.windows.Window
+import org.apache.flink.streaming.api.windowing.windows.GlobalWindow
import org.apache.flink.table.api.{StreamQueryConfig, Types}
-import
org.apache.flink.table.runtime.triggers.CountTriggerWithCleanupState.Sum
+import
org.apache.flink.table.runtime.triggers.StateCleaningCountTrigger.Sum
-class CountTriggerWithCleanupState[W <: Window](queryConfig:
StreamQueryConfig, maxCount: Long)
- extends Trigger[Any, W] {
+/**
+ * A {@link Trigger} that fires once the count of elements in a pane
reaches the given count
+ * or the cleanup timer is triggered.
+ */
+@PublicEvolving
--- End diff --
We only annotate classes the core, DataSet and DataStream APIs with
stability annotations.
`@PublicEvolving` should be removed.
> Enable QueryConfig in count base GroupWindow
> --------------------------------------------
>
> Key: FLINK-6583
> URL: https://issues.apache.org/jira/browse/FLINK-6583
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Affects Versions: 1.3.0, 1.4.0
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> Enable QueryConfig in count base GroupWindow by Add a custom Trigger
> `CountTriggerWithCleanupState`. See more in FLINK-6491.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
