[ 
https://issues.apache.org/jira/browse/FLINK-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015387#comment-16015387
 ] 

ASF GitHub Bot commented on FLINK-6583:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3919#discussion_r117183206
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala
 ---
    @@ -245,6 +264,7 @@ object DataStreamGroupWindowAggregate {
         case SlidingGroupWindow(_, timeField, size, slide)
             if isProctimeAttribute(timeField) && isRowCountLiteral(size) =>
           stream.countWindow(toLong(size), toLong(slide))
    +      .trigger(StateCleaningCountTrigger.of(queryConfig, toLong(slide)));
    --- End diff --
    
    `slide` is correct here (check `KeyedStream.countWindow(long, long)`).
    
    The default trigger is replaced by a trigger that additional registers a 
clean up timer. The trigger policy based on counts is still the same.


> Enable QueryConfig in count base GroupWindow
> --------------------------------------------
>
>                 Key: FLINK-6583
>                 URL: https://issues.apache.org/jira/browse/FLINK-6583
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>             Fix For: 1.3.0, 1.4.0
>
>
> Enable QueryConfig in count base GroupWindow by Add a custom Trigger 
> `CountTriggerWithCleanupState`. See more in FLINK-6491.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to