[
https://issues.apache.org/jira/browse/FLINK-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015389#comment-16015389
]
ASF GitHub Bot commented on FLINK-6583:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3919#discussion_r117183489
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala
---
@@ -131,6 +135,19 @@ class DataStreamGroupWindowAggregate(
"non-windowed GroupBy aggregation.")
}
+ val isCountWindow = window match {
+ case TumblingGroupWindow(_, _, size) if isRowCountLiteral(size) =>
true
+ case SlidingGroupWindow(_, _, size, _) if isRowCountLiteral(size) =>
true
+ case _ => false
+ }
+
+ if (isCountWindow && grouping.length > 0 &&
queryConfig.getMinIdleStateRetentionTime < 0) {
+ LOG.warn(
--- End diff --
I think this can be argued in both ways. If we log an error message could
also throw an exception and prevent the program to be executed. However, there
are also other strategies to deal with state cleanup, e.g., by configuring
RocksDB.
> Enable QueryConfig in count base GroupWindow
> --------------------------------------------
>
> Key: FLINK-6583
> URL: https://issues.apache.org/jira/browse/FLINK-6583
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.3.0, 1.4.0
> Reporter: sunjincheng
> Assignee: sunjincheng
> Fix For: 1.3.0, 1.4.0
>
>
> Enable QueryConfig in count base GroupWindow by Add a custom Trigger
> `CountTriggerWithCleanupState`. See more in FLINK-6491.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
