Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157541024
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SubpartitionTestBase.java
---
@@ -62,7 +70,14 @@ public void testAddAfterRelease() throws Exception {
try {
subpartition.release();
+ assertEquals(0, subpartition.getTotalNumberOfBuffers());
+ assertEquals(0, subpartition.getBuffersInBacklog());
+ assertEquals(0, subpartition.getTotalNumberOfBytes());
+
assertFalse(subpartition.add(mock(Buffer.class)));
+ assertEquals(0, subpartition.getTotalNumberOfBuffers());
+ assertEquals(0, subpartition.getBuffersInBacklog());
--- End diff --
same here - please test with a real `Buffer` instance
---
