Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r157540910
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SubpartitionTestBase.java
---
@@ -47,7 +48,14 @@ public void testAddAfterFinish() throws Exception {
try {
subpartition.finish();
+ assertEquals(1, subpartition.getTotalNumberOfBuffers());
+ assertEquals(0, subpartition.getBuffersInBacklog());
+ assertEquals(4, subpartition.getTotalNumberOfBytes());
+
assertFalse(subpartition.add(mock(Buffer.class)));
+ assertEquals(1, subpartition.getTotalNumberOfBuffers());
+ assertEquals(0, subpartition.getBuffersInBacklog());
--- End diff --
Actually, this never increases the backlog, even if the subpartition is not
finished, since `buffer.isBuffer()` for a `mock(Buffer.class)` returns `false`.
Can you test with a real `Buffer` instead?
---
