[GitHub] flink pull request #4559: [FLINK-7468][network] Implement sender backlog log...

[NicoK]

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4559#discussion_r157539147
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
 ---
    @@ -239,6 +261,10 @@ public void 
testConsumeSpillablePartitionSpilledDuringConsume() throws Exception
     
                // Spill now
                assertEquals(2, partition.releaseMemory());
    +           // still same statistics:
    +           assertEquals(4, partition.getTotalNumberOfBuffers());
    +           assertEquals(2, partition.getBuffersInBacklog());
    +           assertEquals(4096 * 3 + 4, partition.getTotalNumberOfBytes());
    --- End diff --
    
    same here - please add the checks to the `reader.getNextBuffer()` lines 
below


---