[ https://issues.apache.org/jira/browse/FLINK-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346601#comment-16346601 ]
ASF GitHub Bot commented on FLINK-8503: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5353#discussion_r165017798 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java --- @@ -175,4 +177,13 @@ final AllocationID allocationId, final Throwable cause, @RpcTimeout final Time timeout); + + /** + * Requests the file upload of the specified type to the cluster's {@link BlobServer}. + * + * @param fileType to upload + * @param timeout for the asynchronous operation + * @return Future which is completed with the {@link TransientBlobKey} of the uploaded file. + */ + CompletableFuture<TransientBlobKey> requestFileUpload(FileType fileType, @RpcTimeout Time timeout); --- End diff -- Yes we do. Good catch. Will apply the change. > Port TaskManagerLogHandler to new REST endpoint > ----------------------------------------------- > > Key: FLINK-8503 > URL: https://issues.apache.org/jira/browse/FLINK-8503 > Project: Flink > Issue Type: Sub-task > Components: REST > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > In order to serve {{TaskExecutor}} log stdout files, we have to port the > {{TaskManagerLogHandler}} to the new REST endpoint. > In order to properly support serving of files, I propose to introduce an > {{AbstractHandler}} which takes a typed request but has not typed response. > That way we can easily output the file contents. -- This message was sent by Atlassian JIRA (v7.6.3#76005)