[
https://issues.apache.org/jira/browse/FLINK-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352333#comment-16352333
]
ASF GitHub Bot commented on FLINK-8503:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5353#discussion_r165950588
--- Diff:
flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java ---
@@ -285,11 +287,22 @@ private static String createMessageHtmlEntry(Class<?>
messageClass, Class<?> emp
dispatcherGatewayRetriever = () -> null;
resourceManagerGatewayRetriever = () -> null;
+ transientBlobService =
NoOpTransientBlobService.INSTANCE;
metricQueryServiceRetriever = path -> null;
}
private DocumentingDispatcherRestEndpoint() {
- super(restConfig, dispatcherGatewayRetriever, config,
handlerConfig, resourceManagerGatewayRetriever, executor,
metricQueryServiceRetriever, NoOpElectionService.INSTANCE,
NoOpFatalErrorHandler.INSTANCE);
+ super(
+ restConfig,
+ dispatcherGatewayRetriever,
+ config,
+ handlerConfig,
+ resourceManagerGatewayRetriever,
+ transientBlobService,
--- End diff --
I don't think we need these `static final` variables. Can just use
`NoOpTransientBlobService.INSTANCE` as a constructor argument.
> Port TaskManagerLogHandler to new REST endpoint
> -----------------------------------------------
>
> Key: FLINK-8503
> URL: https://issues.apache.org/jira/browse/FLINK-8503
> Project: Flink
> Issue Type: Sub-task
> Components: REST
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to serve {{TaskExecutor}} log stdout files, we have to port the
> {{TaskManagerLogHandler}} to the new REST endpoint.
> In order to properly support serving of files, I propose to introduce an
> {{AbstractHandler}} which takes a typed request but has not typed response.
> That way we can easily output the file contents.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
