[
https://issues.apache.org/jira/browse/FLINK-8503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352332#comment-16352332
]
ASF GitHub Bot commented on FLINK-8503:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5353#discussion_r165962518
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/TransientBlobCache.java
---
@@ -222,7 +221,13 @@ public File getStorageLocation(@Nullable JobID jobId,
BlobKey key) throws IOExce
}
private BlobClient createClient() throws IOException {
- return new BlobClient(serverAddress, blobClientConfig);
+ final InetSocketAddress currentServerAddress = serverAddress;
+
+ if (currentServerAddress != null) {
+ return new BlobClient(serverAddress, blobClientConfig);
--- End diff --
I think you should use `currentServerAddress`, or the creation can fail
with an NPE.
> Port TaskManagerLogHandler to new REST endpoint
> -----------------------------------------------
>
> Key: FLINK-8503
> URL: https://issues.apache.org/jira/browse/FLINK-8503
> Project: Flink
> Issue Type: Sub-task
> Components: REST
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to serve {{TaskExecutor}} log stdout files, we have to port the
> {{TaskManagerLogHandler}} to the new REST endpoint.
> In order to properly support serving of files, I propose to introduce an
> {{AbstractHandler}} which takes a typed request but has not typed response.
> That way we can easily output the file contents.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
