[GitHub] flink pull request #5410: [FLINK-8468] [RabbitMQ Connector] Take advantage o...

[GJL]

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5410#discussion_r193126347
  
    --- Diff: 
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
 ---
    @@ -83,7 +103,22 @@ public void throwExceptionIfChannelIsNull() throws 
Exception {
        }
     
        private RMQSink<String> createRMQSink() throws Exception {
    -           RMQSink rmqSink = new RMQSink<String>(rmqConnectionConfig, 
QUEUE_NAME, serializationSchema);
    +           RMQSink<String> rmqSink = new 
RMQSink<String>(rmqConnectionConfig, QUEUE_NAME, serializationSchema);
    +           rmqSink.open(new Configuration());
    +           return rmqSink;
    +   }
    +
    +   private RMQSink<String> createRMQSinkFeatured() throws Exception {
    +           publishOptions = new DummyPublishOptions();
    +           RMQSink<String> rmqSink = new 
RMQSink<String>(rmqConnectionConfig, serializationSchema, publishOptions);
    +           rmqSink.open(new Configuration());
    +           return rmqSink;
    +   }
    +
    +   private RMQSink<String> createRMQSinkFeaturedReturnHandler() throws 
Exception {
    --- End diff --
    
    How about `createRMQSinkWithReturnHandler()`?


---