Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193070753
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -66,12 +79,19 @@ public void before() throws Exception {
}
@Test
- public void openCallDeclaresQueue() throws Exception {
+ public void openCallDeclaresQueueInStandardMode() throws Exception {
createRMQSink();
verify(channel).queueDeclare(QUEUE_NAME, false, false, false,
null);
}
+ @Test
+ public void openCallDontDeclaresQueueInFeaturedMode() throws Exception {
+ doThrow(Exception.class).when(channel).queueDeclare(null,
false, false, false, null);
--- End diff --
There is no assertion in this test. I would re-write it as:
```
@Test
public void openCallDontDeclaresQueueInFeaturedMode() throws Exception {
createRMQSinkFeatured();
verify(channel, never()).queueDeclare(null, false, false,
false, null);
}
```
---
