Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/967#issuecomment-127050940
Wow, impressive contribution! I would very much like to add SSP to Flink.
This is quite a lot, so it may take a bit to review and merge.
Here are some initial thoughts:
- The SSP slack is defined as a job-wide parameter. Can you make it a
parameter of the respective bulk iteration (that also has the mode PLAIN/SSP) ?
- The code includes Apache Ignite as a parameter server. Is it possible
to make this independent of Ignite? I know that SSP is usually used in
parameter server ML settings, but I would like to not tie Ignite (another big
dependency) into the Flink codebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
