[ 
https://issues.apache.org/jira/browse/FLINK-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579600#comment-16579600
 ] 

ASF GitHub Bot commented on FLINK-10137:
----------------------------------------

GJL opened a new pull request #6550: [FLINK-10137][YARN] Log completed 
containers.
URL: https://github.com/apache/flink/pull/6550
 
 
   ## What is the purpose of the change
   
   *This adds logging of completed YARN containers.*
   
   
   ## Brief change log
   
     - *Log completed YARN containers.*
     - *Change variable name: `list` ~> `statuses`*
     - *Always log TM closing reason.*
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> YARN: Log completed Containers
> ------------------------------
>
>                 Key: FLINK-10137
>                 URL: https://issues.apache.org/jira/browse/FLINK-10137
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination, ResourceManager, YARN
>    Affects Versions: 1.5.2, 1.6.0
>            Reporter: Gary Yao
>            Assignee: Gary Yao
>            Priority: Major
>              Labels: pull-request-available
>
> Currently the Flink logs do not reveal why a YARN container completed. 
> {{YarnResourceManager}} should log the {{ContainerStatus}} when the YARN 
> ResourceManager reports containers to be completed. 
> *Acceptance Criteria*
> * {{YarnResourceManager#onContainersCompleted(List<ContainerStatus>)}} logs 
> completed containers.
> * {{ResourceManager#closeTaskManagerConnection(ResourceID, Exception)}} 
> should always log the message in the exception.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to