[
https://issues.apache.org/jira/browse/FLINK-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580126#comment-16580126
]
ASF GitHub Bot commented on FLINK-10137:
----------------------------------------
GJL commented on a change in pull request #6550: [FLINK-10137][YARN] Log
completed containers.
URL: https://github.com/apache/flink/pull/6550#discussion_r210040202
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -323,9 +323,10 @@ public float getProgress() {
}
@Override
- public void onContainersCompleted(final List<ContainerStatus> list) {
+ public void onContainersCompleted(final List<ContainerStatus> statuses)
{
runAsync(() -> {
- for (final ContainerStatus containerStatus :
list) {
+ log.debug("YARN ResourceManager reported the
following containers completed: {}.", statuses);
Review comment:
That depends on the `List` implementation. At least
`java.util.AbstractCollection` has a meaningful string representation. The List
returned by Hadoop 2.8 as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> YARN: Log completed Containers
> ------------------------------
>
> Key: FLINK-10137
> URL: https://issues.apache.org/jira/browse/FLINK-10137
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination, ResourceManager, YARN
> Affects Versions: 1.5.2, 1.6.0
> Reporter: Gary Yao
> Assignee: Gary Yao
> Priority: Major
> Labels: pull-request-available
>
> Currently the Flink logs do not reveal why a YARN container completed.
> {{YarnResourceManager}} should log the {{ContainerStatus}} when the YARN
> ResourceManager reports containers to be completed.
> *Acceptance Criteria*
> * {{YarnResourceManager#onContainersCompleted(List<ContainerStatus>)}} logs
> completed containers.
> * {{ResourceManager#closeTaskManagerConnection(ResourceID, Exception)}}
> should always log the message in the exception.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
