[
https://issues.apache.org/jira/browse/FLINK-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596259#comment-16596259
]
ASF GitHub Bot commented on FLINK-10137:
----------------------------------------
zentol closed pull request #6550: [FLINK-10137][YARN] Log completed containers.
URL: https://github.com/apache/flink/pull/6550
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
b/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
index 7a54224e59b..eb6df19a4ed 100644
---
a/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
+++
b/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
@@ -796,7 +796,10 @@ protected void closeTaskManagerConnection(final ResourceID
resourceID, final Exc
workerRegistration.getTaskExecutorGateway().disconnectResourceManager(cause);
} else {
- log.debug("No open TaskExecutor connection {}. Ignoring
close TaskExecutor connection.", resourceID);
+ log.debug(
+ "No open TaskExecutor connection {}. Ignoring
close TaskExecutor connection. Closing reason was: {}",
+ resourceID,
+ cause.getMessage());
}
}
diff --git
a/flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
b/flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
index 876e8587134..cf3588f6593 100644
--- a/flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
+++ b/flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
@@ -323,9 +323,10 @@ public float getProgress() {
}
@Override
- public void onContainersCompleted(final List<ContainerStatus> list) {
+ public void onContainersCompleted(final List<ContainerStatus> statuses)
{
runAsync(() -> {
- for (final ContainerStatus containerStatus :
list) {
+ log.debug("YARN ResourceManager reported the
following containers completed: {}.", statuses);
+ for (final ContainerStatus containerStatus :
statuses) {
final ResourceID resourceId = new
ResourceID(containerStatus.getContainerId().toString());
final YarnWorkerNode yarnWorkerNode =
workerNodeMap.remove(resourceId);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> YARN: Log completed Containers
> ------------------------------
>
> Key: FLINK-10137
> URL: https://issues.apache.org/jira/browse/FLINK-10137
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination, ResourceManager, YARN
> Affects Versions: 1.5.2, 1.6.0
> Reporter: Gary Yao
> Assignee: Gary Yao
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.1, 1.7.0, 1.5.4
>
>
> Currently the Flink logs do not reveal why a YARN container completed.
> {{YarnResourceManager}} should log the {{ContainerStatus}} when the YARN
> ResourceManager reports containers to be completed.
> *Acceptance Criteria*
> * {{YarnResourceManager#onContainersCompleted(List<ContainerStatus>)}} logs
> completed containers.
> * {{ResourceManager#closeTaskManagerConnection(ResourceID, Exception)}}
> should always log the message in the exception.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
