[ https://issues.apache.org/jira/browse/FLINK-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659436#comment-16659436 ]
ASF GitHub Bot commented on FLINK-10637: ---------------------------------------- tillrohrmann opened a new pull request #6899: [FLINK-10637] Use MiniClusterResource for tests in flink-runtime URL: https://github.com/apache/flink/pull/6899 ## What is the purpose of the change Rename MiniClusterResource into MiniClusterWithClientResource and move base functionality in the form of MiniClusterResource into flink-runtime. The new base class simply starts a MiniCluster with random ports. Moreover, this commit lets almost all tests in flink-runtime use the MiniClusterResource to guarantee that there are no port conflicts between concurrently executed tests. ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Start MiniCluster with random REST port > --------------------------------------- > > Key: FLINK-10637 > URL: https://issues.apache.org/jira/browse/FLINK-10637 > Project: Flink > Issue Type: Improvement > Components: Tests > Affects Versions: 1.5.4, 1.6.1, 1.7.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Critical > Labels: pull-request-available > Fix For: 1.5.6, 1.6.3, 1.7.0 > > > The {{MiniCluster}} picks a random port for the {{RpcService}} but not for > the REST server endpoint. Due to this it falls back to {{8081}}. This can > lead to port conflicts if tests are executed concurrently. > I propose to rename the {{MiniClusterResource}} into > {{MiniClusterResourceWithRestClient}} and add a new {{MiniClusterResource}} > which only starts a {{MiniCluster}} with the REST port set to 0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)