[
https://issues.apache.org/jira/browse/FLINK-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659536#comment-16659536
]
ASF GitHub Bot commented on FLINK-10637:
----------------------------------------
zentol commented on a change in pull request #6899: [FLINK-10637] Use
MiniClusterResource for tests in flink-runtime
URL: https://github.com/apache/flink/pull/6899#discussion_r227037526
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BigUserProgramJobSubmitITCase.java
##########
@@ -122,8 +83,9 @@ public String map(Integer value) throws Exception {
}).addSink(resultSink);
JobGraph jobGraph =
StreamingJobGraphGenerator.createJobGraph(env.getStreamGraph());
- CLIENT.setDetached(false);
- CLIENT.submitJob(jobGraph,
BigUserProgramJobSubmitITCase.class.getClassLoader());
+ final ClusterClient<?> clusterClient =
MINI_CLUSTER_RESOURCE.getClusterClient();
+ clusterClient.setDetached(false);
+ clusterClient.submitJob(jobGraph,
BigUserProgramJobSubmitITCase.class.getClassLoader());
Review comment:
You're changing the behavior of this test since it no longer uses a REST
client. This should be reverted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Start MiniCluster with random REST port
> ---------------------------------------
>
> Key: FLINK-10637
> URL: https://issues.apache.org/jira/browse/FLINK-10637
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.5.4, 1.6.1, 1.7.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.5.6, 1.6.3, 1.7.0
>
>
> The {{MiniCluster}} picks a random port for the {{RpcService}} but not for
> the REST server endpoint. Due to this it falls back to {{8081}}. This can
> lead to port conflicts if tests are executed concurrently.
> I propose to rename the {{MiniClusterResource}} into
> {{MiniClusterResourceWithRestClient}} and add a new {{MiniClusterResource}}
> which only starts a {{MiniCluster}} with the REST port set to 0.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
