azagrebin commented on a change in pull request #7822: [FLINK-11726][network]
Refactor the creation of ResultPartition and InputGate into NetworkEnvironment
URL: https://github.com/apache/flink/pull/7822#discussion_r267510295
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -88,6 +104,12 @@
private final boolean enableCreditBased;
+ private final boolean enableNetworkDetailedMetrics;
+
+ private final ConcurrentHashMap<String, ResultPartition[]>
allPartitions;
Review comment:
resultPartitionManager already has "partition by execution id" mapping.
why do we need to introduce extra `taskId`? task seems to be identifiable by
execution id.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
