azagrebin commented on a change in pull request #7822: [FLINK-11726][network]
Refactor the creation of ResultPartition and InputGate into NetworkEnvironment
URL: https://github.com/apache/flink/pull/7822#discussion_r267808414
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -88,6 +104,12 @@
private final boolean enableCreditBased;
+ private final boolean enableNetworkDetailedMetrics;
+
+ private final ConcurrentHashMap<String, ResultPartition[]>
allPartitions;
Review comment:
At the first glance, it looks like we could include task name into
`ResultPartitionDeploymentDescriptor` as well in #7835 along with `executionId`.
Alternatively, we could add `ShuffleTaskInfo` produced in Task from
`TaskInfo` which would include debug name and execution id. Task could pass
this `ShuffleTaskInfo` along with RPDDs/IGDDs to partition/gate create methods.
This way we do not need to duplicate its info in all RPDDs/IGDDs, like in #7835.
I would still index by `executionId` if needed (add to method at the moment
before #7835), because it is more reliable and concise than task name + id used
for debug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
