azagrebin commented on a change in pull request #7822: [FLINK-11726][network]
Refactor the creation of ResultPartition and InputGate into NetworkEnvironment
URL: https://github.com/apache/flink/pull/7822#discussion_r267814622
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -421,6 +509,25 @@ public void shutdown() {
LOG.warn("Network buffer pool did not shut down
properly.", t);
}
+ for (ResultPartition[] resultPartitions :
allPartitions.values()) {
+ for (ResultPartition partition :
resultPartitions) {
+ partition.destroyBufferPool();
Review comment:
Looks like, these partition/gates releases were supposed to happen on task
cancel or finish.
Do you think we should have them again here? to double-check everything is
released? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
