[ https://issues.apache.org/jira/browse/FLINK-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14733586#comment-14733586 ]
ASF GitHub Bot commented on FLINK-2626: --------------------------------------- Github user HuangWHWHW commented on a diff in the pull request: https://github.com/apache/flink/pull/1096#discussion_r38856538 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/accumulators/AverageAccumulatorTest.java --- @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.common.accumulators; + +import org.junit.Test; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; + +/** --- End diff -- Sorry...comment? You mean this class documentation----'/*XXX*/'? > Add a AverageAccumulator for FLINK-Accumulator > ---------------------------------------------- > > Key: FLINK-2626 > URL: https://issues.apache.org/jira/browse/FLINK-2626 > Project: Flink > Issue Type: New Feature > Components: Core > Affects Versions: 0.10 > Reporter: Huang Wei > Fix For: 0.10 > > Original Estimate: 168h > Remaining Estimate: 168h > > Add a AverageAccumulator for Flink-Accumulator to calculate the average of > values. > The feature is like Storm-MultiReducedMetric. > Feature in detail: > 1.This class is named AverageAccumulator(any suggestion? I`m not good at > English name) and implements SimpleAccumulator. > 2.This class support long, integer and double input. > 3.This class will return a double value as the average when the method > getLocalValue() called. > 4.Member method description: > * add(): > A variety of add() method to support different inputs(e.g. Double, double, > Long, long, Integer, int). > It will add the input value and make the count + 1 each time. > * public Double getLocalValue(): > To return the sum of value dividing count as average and the result will be > "double". > * public void resetLocal(): > To reset the value and count. > It won`t be called automatically and it will be better to call this every > time the getLocalValue() method called. > * public void merge(Accumulator<Double, Double> other): > To merge another accumulator(only support AverageAccumulator). > * public AverageAccumulator clone(): > To return the whole current AverageAccumulator class. -- This message was sent by Atlassian JIRA (v6.3.4#6332)